Skip to content

Conversation

@Rakshith-R
Copy link
Member

@Rakshith-R Rakshith-R commented Dec 4, 2025

Ceph-CSI introduced a new flag 'enable-fencing' disabled-by-default. When enabled driver can set the client address per node in the volume metadata during NodeStageVolume operation, and fence the node in ControllerUnpublishVolume.
Auto Unfence will occur in CSIAddonsNode GetFenceClient request.

Depends-on: https://github.com/ceph/ceph-csi/pull/5828

Refer: https://issues.redhat.com/browse/RHSTOR-7645

Previous attempt to
enable: #442
and then disabled in #493

Ceph-CSI introduced a new flag 'enable-fencing' disabled-by-default.
When enabled driver can set the client address per node in
the volume metadata during NodeStageVolume operation, and
fence the node in ControllerUnpublishVolume.
Auto Unfence will occur in CSIAddonsNode GetFenceClient request.

Signed-off-by: Rakshith R <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rakshith-R
Once this PR has been reviewed and has the lgtm label, please assign madhu-1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rakshith-R Rakshith-R changed the title csi: enable fencing in OperatorConfig.DriverSpecDefault RHSTOR-7645: csi: enable fencing in OperatorConfig.DriverSpecDefault Dec 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Dec 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2025

@Rakshith-R: This pull request references RHSTOR-7645 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "odf-4.20" version, but no target version was set.

Details

In response to this:

Ceph-CSI introduced a new flag 'enable-fencing' disabled-by-default. When enabled driver can set the client address per node in the volume metadata during NodeStageVolume operation, and fence the node in ControllerUnpublishVolume.
Auto Unfence will occur in CSIAddonsNode GetFenceClient request.

Depends-on: https://github.com/ceph/ceph-csi/pull/5828

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2025

@Rakshith-R: This pull request references RHSTOR-7645 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "odf-4.20" version, but no target version was set.

Details

In response to this:

Ceph-CSI introduced a new flag 'enable-fencing' disabled-by-default. When enabled driver can set the client address per node in the volume metadata during NodeStageVolume operation, and fence the node in ControllerUnpublishVolume.
Auto Unfence will occur in CSIAddonsNode GetFenceClient request.

Depends-on: https://github.com/ceph/ceph-csi/pull/5828

Refer: https://issues.redhat.com/browse/RHSTOR-7645

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Rakshith-R Rakshith-R changed the title RHSTOR-7645: csi: enable fencing in OperatorConfig.DriverSpecDefault csi: enable fencing in OperatorConfig.DriverSpecDefault Dec 4, 2025
@openshift-ci-robot
Copy link

@Rakshith-R: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Ceph-CSI introduced a new flag 'enable-fencing' disabled-by-default. When enabled driver can set the client address per node in the volume metadata during NodeStageVolume operation, and fence the node in ControllerUnpublishVolume.
Auto Unfence will occur in CSIAddonsNode GetFenceClient request.

Depends-on: https://github.com/ceph/ceph-csi/pull/5828

Refer: https://issues.redhat.com/browse/RHSTOR-7645

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Dec 4, 2025
@Rakshith-R
Copy link
Member Author

/DNM
/cc @Madhu-1

@openshift-ci openshift-ci bot requested a review from Madhu-1 December 4, 2025 13:51
@Rakshith-R
Copy link
Member Author

/hold

@Rakshith-R Rakshith-R marked this pull request as ready for review December 4, 2025 13:51
@Rakshith-R
Copy link
Member Author

/un-hold

@Rakshith-R
Copy link
Member Author

/unhold

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 15, 2025

/hold until the CSI PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants